Skip to content

Help wanted Issue search#604

Merged
andrew merged 8 commits into
librariesio:masterfrom
samjacobclift:feature/help_wanted_issue_search
Jun 2, 2016
Merged

Help wanted Issue search#604
andrew merged 8 commits into
librariesio:masterfrom
samjacobclift:feature/help_wanted_issue_search

Conversation

@samjacobclift
Copy link
Copy Markdown
Contributor

@samjacobclift samjacobclift commented May 28, 2016

Comment thread app/models/concerns/issue_search.rb Outdated
settings index: { number_of_shards: 1, number_of_replicas: 0 } do
mapping do
indexes :full_title, :analyzer => 'snowball', :boost => 6
indexes :exact_title, :index => :not_analyzed, :boost => 2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the exact title on this, it's just a hack for priority in search based on exact matching

end

def exact_title
full_title
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this

Comment thread app/models/concerns/issue_search.rb Outdated
indexes :github_repository_license

indexes :number
indexes :labels
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be indexes :labels, :analyzer => 'keyword'

@BPScott
Copy link
Copy Markdown

BPScott commented May 28, 2016

Rather than hard coding to the "help wanted" label it'd be neat if the issue search could allow facets so you could search for "ham" to give all issues that mention ham in the title/description or "label:'help wanted'" to search for for issues tagged with that label. We could even do "repo:librariesio/libraries.io" to search within a given repo.

@andrew andrew merged commit ed8b034 into librariesio:master Jun 2, 2016
@andrew
Copy link
Copy Markdown
Contributor

andrew commented Jun 2, 2016

Merging this, making tweaks and hopefully deploying it tonight ✊

Thanks so much for working on this @royka!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants