Index without legacy scanning information#67
Merged
brycekbargar merged 5 commits intolibrary-data-platform:release-v4.0.0from Mar 9, 2026
Merged
Conversation
brycekbargar
merged commit f397d31
into
library-data-platform:release-v4.0.0
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous indexing process relied on information saved during the scanning/transformation process. While I could still do it that way I'd like to make these steps independent so they can be better distributed in the future. While only postgres was indexed there's really no harm to also indexing duckdb. I've also realized that the ldlite system generated columns like __id and __o are almost never used in queries so they do not need to be indexed. At some point in the past the unit tests for indexing were accidentally removed and they're restored in this PR.