test: cover claude code skip permissions args#1364
Merged
houko merged 5 commits intolibrefang:mainfrom Mar 21, 2026
Merged
Conversation
houko
approved these changes
Mar 21, 2026
Contributor
houko
left a comment
There was a problem hiding this comment.
Nice refactor — extracting build_command_args eliminates the duplicated arg construction between complete and complete_stream. The three test cases cover the key combinations (skip_permissions on/off, verbose on/off). LGTM.
Contributor
|
@TechWizard9999 sorry, conflict, please resolve then I will merge . |
1354bc9 to
f630413
Compare
Contributor
Author
|
@houko Could you please check it now ? |
Contributor
|
@TechWizard9999 sorry need format |
houko
approved these changes
Mar 21, 2026
Contributor
houko
left a comment
There was a problem hiding this comment.
Code review: LGTM
- Refactoring is logic-equivalent —
build_command_args()correctly extracts all CLI arg construction from bothcomplete()andstream() - Argument order change (
--modelbefore--add-dir) is irrelevant for CLI flag parsing - Test coverage for
--dangerously-skip-permissionson/off is solid - Minor nit:
.to_string()on&strargs is redundant but harmless
Clean PR, no issues found.
This was referenced Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dangerously-skip-permissionsin complete mode--dangerously-skip-permissionsin streaming modeTesting