fix: remove unused find_latest_stable_tag in release.rs#1551
Merged
Conversation
The function became dead code after #1547 refactored tag lookup to use find_latest_tag with an include_prerelease parameter. changelog.rs has its own copy that is still in use.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_latest_stable_taginxtask/src/release.rsbecame dead code after fix: release tool compares against latest tag including prereleases #1547 refactored tag lookup to usefind_latest_tagwith aninclude_prereleaseparameter, causing-D warningsto reject the buildchangelog.rshas its own independent copy still in use)Test plan
cargo clippy -p xtask --all-targets -- -D warningspasses with zero warnings🤖 Generated with Claude Code