fix(test): centralize registry sync to prevent parallel git clone races#1651
Merged
Conversation
Multiple test modules across crates called sync_registry() directly, causing concurrent git clone races when tests run in parallel threads. Move the auto-sync logic into resolve_home_dir_for_tests() behind a OnceLock so the registry is synced exactly once per process. All test helpers now just call resolve_home_dir_for_tests() without manual sync. Affected crates: runtime, kernel, extensions, hands.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
area/runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI 测试三平台全挂，根因是多个 crate 的测试并行调
sync_registry()→ 并发git clone同一目录 → 竞争失败。修复
把 auto-sync 逻辑收敛到
resolve_home_dir_for_tests()内部，用OnceLock确保每个进程只同步一次。各 crate 的 test helper 简化为直接调用该函数。改动文件
registry_sync.rsresolve_home_dir_for_tests()内置 OnceLock + auto-syncmodel_catalog.rstest_catalog()简化routing.rstest_catalog()从Default改为用共享 homekernel/metering.rstest_catalog()简化kernel/router.rsensure_registry()简化extensions/registry.rsensure_registry()简化extensions/installer.rsensure_registry()简化hands/registry.rsensure_test_home()简化Test plan
cargo test --workspace --lib本地全绿 (3063 passed)