fix: re-land SSRF DNS pinning to prevent TOCTOU rebinding attacks#1681
Merged
Conversation
The previous DNS pinning fix (PR #1653) was merged but the code never landed on main. This re-implements the same fixes: - check_ssrf() now returns SsrfResolution with resolved IPs instead of () - WebFetchEngine builds a per-request DNS-pinned client via reqwest .resolve() so the HTTP stack connects only to validated IPs - is_ssrf_target() in host_functions.rs returns SsrfResolved and host_net_fetch() pins DNS on the WASM sandbox path too - DNS resolution failure is now treated as BLOCKED (fixes the silent pass-through `if let Ok(addrs)` pattern) - Remove dead `client` field from WebFetchEngine (was #1678)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1653 was merged but the code never landed on main. This re-implements:
check_ssrf()returns resolved IPs, caller pins DNS via reqwest.resolve()is_ssrf_target()in host_functions.rs does the same for WASM sandbox pathclientfield from WebFetchEngineTest plan