fix(xtask): cap sysinfo at 0.38 to honor 1.94.1 MSRV#5183
Merged
Conversation
The entire sysinfo 0.39.x line requires rustc 1.95, which exceeds this workspace's pinned MSRV (Cargo.toml rust-version = 1.94.1). cargo resolved sysinfo to 0.39.1, breaking `cargo xtask release` on stable 1.94.1 with an unsupported-rustc error. Cap the xtask dependency at "0.38"; the resolver picks 0.38.4, which needs only rustc 1.88 and exposes the identical probe API xtask uses (System::new_with_specifics / RefreshKind::nothing / MemoryRefreshKind::nothing().with_ram / total_memory). Cargo.lock: only the sysinfo package entry changes version; the remaining edits normalize pre-existing stale windows-sys / windows-link dependency edges (no package added, removed, or version-bumped) that cargo rewrites on any lock regeneration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo xtask release(andjust release) fails on stable rustc 1.94.1:xtask/Cargo.tomldeclaredsysinfo = "0.39". The entire 0.39.x line(0.39.0 / 0.39.1 / 0.39.2) requires rustc 1.95, which exceeds this
workspace's deliberately pinned MSRV —
Cargo.tomlrust-version = "1.94.1",reinforced by the comment in
rust-toolchain.tomlrequiring new code torespect the declared MSRV. cargo resolved to 0.39.1 and broke the build.
Change
xtask/Cargo.toml:sysinfoversion requirement"0.39"→"0.38",with a comment explaining the MSRV cap.
Cargo.lock:sysinfo0.39.1→0.38.4(needs only rustc 1.88).0.38.4 exposes the identical API surface xtask consumes in
xtask/src/local_check_mode.rs:75-83(System::new_with_specifics,RefreshKind::nothing(),MemoryRefreshKind::nothing().with_ram(),total_memory()), so the downgrade is API-safe.About the Cargo.lock diff size
Only the sysinfo package entry changes version. No other package is
added, removed, or version-bumped. The remaining ~17 changed lines
normalize pre-existing stale
windows-sys/windows-linkdependencyedges (those package versions already existed in the committed lock);
cargo rewrites these on any lock regeneration regardless of this change.
Verified:
git diff Cargo.lock | grep -E '^[+-]\[\[package\]\]|^[+-]name = 'returns nothing.
Verification
cargo update sysinfo --precise 0.38.4 --dry-run→ reports only thesysinfo downgrade.
cargo check -p xtask→Finishedin 29.57s, zero warnings, againstsysinfo 0.38.4.
Out-of-scope follow-ups
None.