Laravel 8.x Shift by Jellyfrog · Pull Request #12235 · librenms/librenms

Jellyfrog · 2020-10-20T14:11:02Z

This pull request includes the changes for upgrading to Laravel 8.x. Feel free to commit any additional changes to the shift-35189 branch.

Before merging, you need to:

Checkout the shift-35189 branch
Review all pull request comments for additional changes
Update your dependencies for Laravel 8
Run composer update (if the scripts fail, add --no-scripts)
Thoroughly test your application (no tests?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

Jellyfrog · 2020-10-20T14:11:03Z

ℹ️ Shift noticed you have additional namespaces in your application. You may use the Consolidate Namespaces Shift to simplify your namespaces into the default Laravel App namespace.

Jellyfrog · 2020-10-20T14:11:04Z

ℹ️ Laravel 8 streamlined the Exception Handler into a single register method to make it easier to add custom logic around rendering or reporting errors within your application.

While this change is not required, Shift recommends comparing yours against the Laravel 8.x version as an opportunity to reduce code and be fully up-to-date.

Jellyfrog · 2020-10-20T14:11:05Z

ℹ️ The RouteServiceProvider no longer prefixes the controller namespace by default in Laravel 8. While you may still set this property, you are encouraged to register your routes using static ::class references.

You may automate the conversion to static class references using the Shift Workbench.

Jellyfrog · 2020-10-20T14:11:05Z

❌ Laravel 8 condenses the RouteServiceProvider as well as configured the new rate limiters. Shift was unable to automate this change. You should compare yours against the Laravel 8.x version and merge any changes.

Jellyfrog · 2020-10-20T14:11:06Z

⚠️ Shift found multiple model factory definitions in database/factories/ModelFactory.php which it may not have properly converted. To receive the full automation you must first split these into individual factories, then request a rerun. You may use the Shift Workbench to help separate your model factory.

Jellyfrog · 2020-10-20T14:11:06Z

ℹ️ Laravel 8 introduced class based factories. Shift automated this change. However, if you were using a community package for factories or other custom code, you should review your factories for additional changes.

If you encounter an issue, you may revert this commit and temporarily install the laravel/legacy-factories package. You may then automate the conversion to class based factories using the Shift Workbench.

Jellyfrog · 2020-10-20T14:11:07Z

ℹ️ Laravel 8 added a uuid column to the failed_jobs table to support the new job batching features.

If your application is currently using the failed_jobs table, you may generate a custom migration for this command by running:

php artisan make:migration AddUuidToFailedJobsTable

Then copy and paste the contents from Shift's AddUuidToFailedJobsTable class.

Jellyfrog · 2020-10-20T14:11:08Z

ℹ️ Laravel 8 added a new ENV variable of LOG_LEVEL. While the log level is defaulted in the configuration, you may take this opportunity to set it accordingly in your environments.

Jellyfrog · 2020-10-20T14:11:09Z

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables. This should make maintaining your config files easier.

You should review this commit for any additional customizations. If you have a lot of customizations, you may wish to undo this commit with git revert and make these config file changes manually.

Jellyfrog · 2020-10-20T14:11:09Z

ℹ️ Shift updated your dependencies for Laravel 8. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 8.

Watch dealing with dependencies for tips on handling package incompatibilities.

Jellyfrog · 2020-10-20T14:11:10Z

⚠️ Laravel 8 now requires PHPUnit 9 which made some configuration changes to its config file. You may automate these changes by running vendor/bin/phpunit --migrate-configuration or comparing your phpunit.xml to the Laravel 8 version and merging any changes.

Jellyfrog · 2020-10-20T14:11:11Z

⚠️ The paginator now uses Tailwind for its default styling in Laravel 8. If you wish to continue using Bootstrap, you should add the following snippet to the boot method of your AppServiceProvider:

\Illuminate\Pagination\Paginator::useBootstrap();

Jellyfrog · 2020-10-20T14:11:12Z

🎉 Congratulations, you're now running the latest version of Laravel.

The following Shifts may be used ensure your application is fully upgraded and easier to maintain in the future:

Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.
Laravel Fixer automates many of the suggestions found by the Laravel Linter and other Shifts.
Tests Generator intelligently generates model factories, HTTP Tests, and unit tests for your application to give you a head start on testing.

You may run these Shifts and stay upgraded forever as well by subscribing to a Shifty Plans.

CLAassistant · 2020-10-20T14:11:13Z

All committers have signed the CLA.

Jellyfrog · 2020-10-21T01:23:30Z

@librenms/reviewers Need help testing this

murrant · 2020-10-25T05:15:00Z

Testing went fine here. I'll test the update next.

In an effort to make upgrading the constantly changing config files easier, Shift defaulted them. This allows you to review the commit diff for once for customizations when you are done Shifting. Moving forward, consider using ENV variables or create a separate config file to allow the core config files to remain as default as possible.

From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html

murrant · 2020-12-02T03:17:54Z

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-69-release-changelog-november-2020/14124/1

Jellyfrog force-pushed the shift-35189 branch 2 times, most recently from 1ee54d5 to 3a0010d Compare October 21, 2020 00:50

Jellyfrog force-pushed the shift-35189 branch from 6f8dcbf to 1215680 Compare October 26, 2020 15:53

laravel-shift and others added 11 commits November 3, 2020 01:50

Shift HTTP kernel and middleware

d2f08e4

Shift service providers

82d9f78

Shift console routes

e0b3efc

Shift to class based factories

20bba36

Namespace seeders

55bac22

Shift PSR-4 autoloading

6eecdf2

Shift Laravel dependencies

ec3f2bb

Shift cleanup

167d7e5

console routes

6daaf69

Jellyfrog added 16 commits November 3, 2020 01:50

composer update

e7ed51b

factories

64dbb8b

phpunit

d223053

bootstrap pagination

cac32e1

model factory

fb741a4

wip

a779e51

Apply fixes from StyleCI (#12236)

1ca1984

wip

29063b1

Apply fixes from StyleCI (#12238)

9565faa

wip

0ff0ea4

wip

7e27264

wip

4a72764

wip

db26664

Apply fixes from StyleCI (#12240)

610ba17

wip

3f99b41

Apply fixes from StyleCI (#12242)

abcfcff

Jellyfrog force-pushed the shift-35189 branch from 1215680 to bbeafd3 Compare November 3, 2020 00:50

composer update

ce5a972

Jellyfrog force-pushed the shift-35189 branch from bbeafd3 to ce5a972 Compare November 3, 2020 01:05

Bump to PHP 7.3 minimum

6a572d7

murrant merged commit 50c8033 into master Nov 3, 2020

murrant deleted the shift-35189 branch November 3, 2020 16:18

murrant added Feature WebUI labels Dec 2, 2020

Uh oh!

Conversation

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

Jellyfrog commented Oct 20, 2020

Uh oh!

CLAassistant commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jellyfrog commented Oct 21, 2020

Uh oh!

murrant commented Oct 25, 2020

Uh oh!

murrant commented Dec 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Oct 20, 2020 •

edited

Loading