Use a proxy server for the PagerDuty transport.#12294
Merged
Jellyfrog merged 2 commits intolibrenms:masterfrom Nov 4, 2020
Merged
Use a proxy server for the PagerDuty transport.#12294Jellyfrog merged 2 commits intolibrenms:masterfrom
Jellyfrog merged 2 commits intolibrenms:masterfrom
Conversation
We don't use the get_guzzle_proxy() function since tcp:// doesn't work with all of the HTTP transports that Guzzle supports. Instead we use the standard get_proxy() function. Tested against Squid
|
|
Jellyfrog
approved these changes
Nov 4, 2020
Member
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-69-release-changelog-november-2020/14124/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PagerDuty transport doesn't support proxy servers. This adds support for that.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.