Skip to content

OSPF View Open/Close Button#12311

Merged
murrant merged 3 commits intolibrenms:masterfrom
SourceDoctor:ospf_open_close_icon
Nov 10, 2020
Merged

OSPF View Open/Close Button#12311
murrant merged 3 commits intolibrenms:masterfrom
SourceDoctor:ospf_open_close_icon

Conversation

@SourceDoctor
Copy link
Copy Markdown
Member

@SourceDoctor SourceDoctor commented Nov 9, 2020

on expanding OSPF View Button stays on a "+" like it's not expanded

before:

image

after:

image

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog
Copy link
Copy Markdown
Member

You could rewrite this page to blade easily instead

@SourceDoctor
Copy link
Copy Markdown
Member Author

@Jellyfrog
Ok, ... i did a little optical fix. ( 3 Lines of Javascript and adding on two positions an id to get values of the "area")
But to get this "nice to have" in i have to rewrite 200 Lines of old code to Controller/Eloquent/Blade which means hours of work and testing just to have another Icon on the Button when OSPF Entry its enrolled?
Not worth it, sry.

@Jellyfrog
Copy link
Copy Markdown
Member

It means someone else have to spend the time doing it tho.

@SourceDoctor
Copy link
Copy Markdown
Member Author

i know what you mean, but i have no time for rewriting this at moment.
Especially knowing in the amount of time which i have to invest in, to get it rewritten correctly.
Also you see the Code changes, that's nothing big/relevant.

@murrant murrant added the WebUI label Nov 10, 2020
@murrant murrant merged commit ac5920f into librenms:master Nov 10, 2020
@murrant
Copy link
Copy Markdown
Member

murrant commented Dec 2, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-69-release-changelog-november-2020/14124/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants