You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
Testers
If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.
@Jellyfrog
Ok, ... i did a little optical fix. ( 3 Lines of Javascript and adding on two positions an id to get values of the "area")
But to get this "nice to have" in i have to rewrite 200 Lines of old code to Controller/Eloquent/Blade which means hours of work and testing just to have another Icon on the Button when OSPF Entry its enrolled?
Not worth it, sry.
i know what you mean, but i have no time for rewriting this at moment.
Especially knowing in the amount of time which i have to invest in, to get it rewritten correctly.
Also you see the Code changes, that's nothing big/relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on expanding OSPF View Button stays on a "+" like it's not expanded
before:
after:
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.