WebUI - Search results for ports

[PipoCanaja]

My NOC is complaining that searchs in LibreNMS gives less details on the port descriptions. Which is true for ports with parsed descriptions, following #13143

This PR restores the behaviour for Parsed Descriptions in Search results as well as PortURL, both using $port->getDescription();
It also removes the code in function.php for generate_port_link(), thx @murrant .

And a setting could be added to enable shorter display in case necessary (@fbourqui )

Before

After

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
• If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[murrant]

I believe I was simply trying to match the existing behavior (which is/was not uniform). I would love to see getDescription() deleted.

Additionally, I think that change was made in a PR before the one you linked.

[murrant]

Please also check generate_port_link()

[PipoCanaja]

Right. I only started my researches and hurried up to try to catch next release. And missed thisgenerate_port_link() which is also part of the game here.

I come with a rather simple patch : restore the full ifAlias.

Also contacted the original PR that created this short view : #13143

[fbourqui]

@PipoCanaja
I sent a pull request to your repo that fix the original minigraph display error, PipoCanaja#2
Added some screenshot so you can see the display error occurring in iftype page (Ports tab).
Could you merge it, it should then update this pull request

[PipoCanaja]

Bonsoir @fbourqui
You can check if it works as expected for you now.
Thanx for the patch !

[fbourqui]

Salut @PipoCanaja
It looks good to me like that, no complain.

[laf]

LGTM

[librenms-bot]

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-3-0-changelog/18403/1