Fix Oxidized Config tab showing when Device OS or Device Type is disabled#13809
Merged
Jellyfrog merged 3 commits intolibrenms:masterfrom Feb 27, 2022
westerterp:feature/fixOxidizedConfigTab
Merged
Fix Oxidized Config tab showing when Device OS or Device Type is disabled#13809Jellyfrog merged 3 commits intolibrenms:masterfrom westerterp:feature/fixOxidizedConfigTab
Jellyfrog merged 3 commits intolibrenms:masterfrom
westerterp:feature/fixOxidizedConfigTab
Conversation
Jellyfrog
reviewed
Feb 21, 2022
Jellyfrog
approved these changes
Feb 27, 2022
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
jerji
pushed a commit
to Beanfield/librenms
that referenced
this pull request
Apr 14, 2022
…bled (librenms#13809) * Fix Oxidized Config tab showing when Device OS or Device Type is disabled Fixes librenms#13808 * StyleCI * Apply Jellyfrogs suggestion to simplify the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Oxidized Config tab showing when Device OS or Device Type is disabled
Fixes #13808
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.