Skip to content

Regression fix from b6a8b602b891d9eb8633f62632c17bdc559cd620#13819

Merged
laf merged 1 commit intolibrenms:masterfrom
Jellyfrog:bug/geoapi
Mar 2, 2022
Merged

Regression fix from b6a8b602b891d9eb8633f62632c17bdc559cd620#13819
laf merged 1 commit intolibrenms:masterfrom
Jellyfrog:bug/geoapi

Conversation

@Jellyfrog
Copy link
Copy Markdown
Member

@Jellyfrog Jellyfrog commented Mar 1, 2022

Fixes #13814

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Copy link
Copy Markdown

@bboy8012 bboy8012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change resolved the issue, and Lat/Long are populating again

Copy link
Copy Markdown

@bboy8012 bboy8012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue resolved with this, GPS coordinates are being populated.

Copy link
Copy Markdown
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laf laf merged commit 5ffbceb into librenms:master Mar 2, 2022
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-3-0-changelog/18403/1

jerji pushed a commit to Beanfield/librenms that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geocoding failing

4 participants