fix db delete on cisco-vrf-lite discovery#13823
Merged
murrant merged 1 commit intolibrenms:masterfrom Mar 8, 2022
Merged
Conversation
lpailhas
force-pushed
the
fixciscovrfdelete
branch
from
589b5ff to
8abfea2
Compare
|
|
lpailhas
force-pushed
the
fixciscovrfdelete
branch
2 times, most recently
from
96d1782 to
6dd940f
Compare
lpailhas
force-pushed
the
fixciscovrfdelete
branch
from
6dd940f to
08f3b21
Compare
murrant
approved these changes
Mar 8, 2022
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
jerji
pushed a commit
to Beanfield/librenms
that referenced
this pull request
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vrf are not correctly delete from the database correctly when you removed an vrf from cisco snmp-server context.
This causing very high discovery polling time as he still trying to poll old vrf context et get some timeout.
tested on cisco nxos and snmpv3 configuration.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.