Skip to content

Remove addHost from ModuleTestHelper#13847

Merged
murrant merged 1 commit intolibrenms:masterfrom
murrant:module_tests_remove_addHost
Mar 13, 2022
Merged

Remove addHost from ModuleTestHelper#13847
murrant merged 1 commit intolibrenms:masterfrom
murrant:module_tests_remove_addHost

Conversation

@murrant
Copy link
Copy Markdown
Member

@murrant murrant commented Mar 13, 2022

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added Refactor Tests 🧪 Test for Code labels Mar 13, 2022
@murrant murrant merged commit 3796272 into librenms:master Mar 13, 2022
@murrant murrant deleted the module_tests_remove_addHost branch March 13, 2022 03:57
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-3-0-changelog/18403/1

jerji pushed a commit to Beanfield/librenms that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants