Add Cisco Err-Disable interface event trap handler

[bonzo81]

Please give a short description what your pull request is for

SNMP Trap hander and test for Cisco Err-Disable Interface Event (Rev1) trap. Requires CISCO-ERR-DISABLE-MIB.

thanks to @Jellyfrog for help with test

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
• If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[bonzo81]

Although the handler and test work, I wasn't sure if my method to extract the ifIndex from the trap using toString then preg_match was the best way to do that. I looked at using substr but couldn't see how to use that when the required string could be single or multiple characters. A review of that would be appreciated.

[Jellyfrog]

You should replace toString() with $trap->findOid('CISCO-ERR-DISABLE-MIB::cErrDisableIfStatusCause')

How you want to get the ifIndex is up to you, one way would be;

>>> explode(".", $trap->findOid('CISCO-ERR-DISABLE-MIB::cErrDisableIfStatusCause'))
=> [
     "CISCO-ERR-DISABLE-MIB::cErrDisableIfStatusCause",
     "858734311",
     "0",
   ]

[Jellyfrog]

You should replace toString() with $trap->findOid('CISCO-ERR-DISABLE-MIB::cErrDisableIfStatusCause')

How you want to get the ifIndex is up to you, one way would be;

>>> explode(".", $trap->findOid('CISCO-ERR-DISABLE-MIB::cErrDisableIfStatusCause'))
=> [
     "CISCO-ERR-DISABLE-MIB::cErrDisableIfStatusCause",
     "858734311",
     "0",
   ]

[laf]

LGTM

[laf]

Great work @bonzo81 👍

[librenms-bot]

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-4-0-changelog/18610/1