Skip to content

Ensure 'add_device' API returns indexed-array (as per doco)#13887

Merged
laf merged 1 commit intolibrenms:masterfrom
claude191:master
Apr 3, 2022
Merged

Ensure 'add_device' API returns indexed-array (as per doco)#13887
laf merged 1 commit intolibrenms:masterfrom
claude191:master

Conversation

@claude191
Copy link
Copy Markdown
Contributor

A prior commit removed the indexed-array around the returned value. This commit restores to prior behaviour so that existing integrations using the API do not have to change,

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Copy link
Copy Markdown
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @claude191

@laf laf merged commit 958556d into librenms:master Apr 3, 2022
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-4-0-changelog/18610/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants