add Sneck support, making it very trivial to use Nagios style checks in a NRPE like manner#13954
Merged
electrocret merged 72 commits intolibrenms:masterfrom Jun 15, 2023
Merged
add Sneck support, making it very trivial to use Nagios style checks in a NRPE like manner#13954electrocret merged 72 commits intolibrenms:masterfrom
electrocret merged 72 commits intolibrenms:masterfrom
Conversation
VVelox
changed the title
VVelox
changed the title
Contributor
Author
|
Converting to draft, want to redo a few things in regards to how alerting is handled. |
Contributor
Author
|
Specifically unhappy with how you can act it, alert can change but it will remain act. Also need to look up at not updating the component when there is no meaningful change. |
Jellyfrog
reviewed
Feb 22, 2023
electrocret
approved these changes
Jun 15, 2023
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
…in a NRPE like manner (librenms#13954) * code stuff done for Sneck * whoops, correct the abs value post adding it post rrd update * return a array for getting the sneck data and nicely print the raw return value * add test stuff and freeze time at 1650911765 for tests * move the freezeTime * add use Illuminate\Support\Carbon; * more test changes * rework freezeTime a bit more * more test stuff * another test * rework it a bit again * correct variable spelling for $time_diff * remove freezeTime as we are using a old version of Laravel * finalize graphs * misc * finalize sneck page * mve the sneck tests as it needs a newer version of laravel than we are using * add documents for sneck * finalize the poller * formatting cleanup * correct comment type * correct the spelling of description * more documentation * save the check returns as metrics * add some more examples * fix some of the sneck alerts and add a few more examples * turn off time to polling by default * suggest using ntp if enabled * since we are zeroing time_to_polling by default, this now works * backout some suggested changes for once we change to larval 9 * remove del_sneck_data as it is no longer used * add more docs on the metrics * php-cs-fixer to fix a few things * update and fix sneck tests * remote a metric from the test * another minor tweak to the test * one more minor change * ahh! derp! think I found it finally... hopefully hanging this for the last time... * now use app data * now logs check changes * add a missing ) * add a missing ) * some style fixes * update the sneck page use to the app data stuff * update the poller to use the new app data * misc * update sneck to log check status changes * correct alert log messages * correct a comment * fix metrics * derp, another fix * test fix * re-order to avoid warning * poller update * update sneck graphs * update sneck graphs * remove a unneeded line * test update for discovery * minor tweaks to the test and fix update the polling a bit * style fix * fix return data printing * fix the test data to include app data * attempted test fix * add config def to apps.sneck.polling_time_diff * cleanup docs a bit * minor config tweaks * minor doc cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sneck is basically NRPE over SNMP.
This means one can easily throw what ever checks on the VM/server/etc when provisioning and poll it via SNMP and get everything there with out having to know what has been setup to poll it.
It tracks totals for each server.
Any found alerts are reported on the application page and stay there until told to clear it.
Screenshots...
graphs, no alert
graphs, alert
alert via example
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.