Skip to content

ns-bsd updated for SNS LTSB 3.7.19#14060

Merged
murrant merged 6 commits intolibrenms:masterfrom
Mar974:patch-1
Aug 8, 2022
Merged

ns-bsd updated for SNS LTSB 3.7.19#14060
murrant merged 6 commits intolibrenms:masterfrom
Mar974:patch-1

Conversation

@Mar974
Copy link
Copy Markdown
Contributor

@Mar974 Mar974 commented Jun 22, 2022

Since the LTSB version of the stromshield OS in 3.7.19 (and also in last version in 3.7.20) the stormshield firewall are seen as a generic device.

The objectID in the MIB as change from ".1.3.6.1.4.1.8072.3.2.8" to ".1.3.6.1.4.1.11256.2.0"

see #12915

Tested on SNS 3.11.10

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Since the LTSB version of the stromshield OS in 3.7.19 (and also in last version in 3.7.20) the stormshield firewall are seen as a generic device.

The objectID in the MIB as change from ".1.3.6.1.4.1.8072.3.2.8" to ".1.3.6.1.4.1.11256.2.0" 

see librenms#12915

Tested on SNS 3.11.10
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 22, 2022

CLA assistant check
All committers have signed the CLA.

@Jellyfrog
Copy link
Copy Markdown
Member

Now it won't work for older firmwares, you need to add both of them.
Could you also post the sysdesc of the device?

Mar974 added 2 commits June 22, 2022 15:45
The sysDescr contain the serial number, exemple NS-BSD SN510XXXXXXXX amd64 so we need to keep the regex
@Mar974
Copy link
Copy Markdown
Contributor Author

Mar974 commented Jun 22, 2022

OK i added a table so the old and the new one will match.
The sysDescr contain the serial number, exemple NS-BSD SN510XXXXXXXX amd64 so we need to keep the regex

@murrant murrant added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Jul 22, 2022
@github-actions
Copy link
Copy Markdown

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@murrant
Copy link
Copy Markdown
Member

murrant commented Jul 22, 2022

Need to add a little test data.
I do think the multi-line array that was already there was a little more readable, just need to add another line - .1.3.6.1.4.1.11256.2.0

@Mar974
Copy link
Copy Markdown
Contributor Author

Mar974 commented Aug 1, 2022

Ok i Changed the array to multi-line and collected some test data, where should i upload the test data ?
ns-bsd_3.11.17.snmprec.txt

@murrant murrant changed the title Update ns-bsd.yaml since SNS updated LTSB 3.7.19 ns-bsd updated for SNS LTSB 3.7.19 Aug 8, 2022
murrant
murrant previously approved these changes Aug 8, 2022
@murrant murrant removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Aug 8, 2022
@murrant murrant merged commit 8179cd9 into librenms:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Device 🖥️ New or added device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants