Device - Basic hatteras dslam integration#14115
Conversation
|
|
Jellyfrog
added
Device 🖥️
|
Please add test data so we can ensure your change is not broken in the future. |
|
snmprec and json testfiles added! |
…enms-hatteras into hatteras-integration
murrant
removed
the
Needs Tests 🦄
includes/definitions/hatteras.yaml
Outdated
| good_if: | ||
| - ras #all interfaces has 'Hatteras' in it... | ||
| discovery_modules: | ||
| ntp: false |
There was a problem hiding this comment.
Any reason to force modules being activated and deactivated ? If they don't fail, better to leave default and remove completely the section. If any of them is harming the device, then only disable these.
Thanx
There was a problem hiding this comment.
Those modules really don't work with this device, so I hope for performance better to disable. wrong approach?
There was a problem hiding this comment.
You gain about 2ms in polling time by disabling these and there could be some random user that wants a specific module enabled or someone adds support for another one, and this will prevent that.
We prefer to have them enabled to allow the users full control. If there is a module that is slow polling when there is no data, then that is a bug.
On my computer for example:
#### Load poller module wireless ####
>> Runtime for poller module 'wireless': 0.0014 seconds with 117056 bytes
includes/definitions/hatteras.yaml
Outdated
| @@ -0,0 +1,58 @@ | |||
| os: hatteras | |||
| text: 'Hatteras Overdue DSLAM' | |||
| type: dslam | |||
There was a problem hiding this comment.
type: dslam does not exist.
type: network is what should be deployed for a network equipment.
html/images/logos/hatteras.svg
Outdated
| <!-- Created with Inkscape (http://www.inkscape.org/) --> | ||
|
|
||
| <svg | ||
| width="200" |
There was a problem hiding this comment.
html/images/logos/hatteras.svg: SVG files must not contain length or width attributes . This is verified automatically and makes the test fail. Could you please remove those from all the SVG files ?
Thanx
PipoCanaja
changed the title
includes/definitions/hatteras.yaml
Outdated
| - serConsole | ||
| good_if: | ||
| - ras #all interfaces has 'Hatteras' in it... | ||
| discovery_modules: |
There was a problem hiding this comment.
We prefer to not set these at all if not for good reason, like if the device crashes or so
…tteras-integration
|
I'm going to remove the modules so we can merge this. |
5 participants
This is a basic integration of Hatteras HN4000 DLSAM. (Now days known as Overture / ADVA. HN4000 is a discontinued product, therefore keeping the name old fashioned).
This PR is mainly for GUI beauty and propper OS detection to work with oxidized Backup. More sensor/discovery might follow. SVGs are vectorized by my own.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.