Skip to content

[apps] Docker only show current containers#14152

Merged
murrant merged 5 commits intolibrenms:masterfrom
Npeca75:rrd-app-filter
Aug 7, 2022
Merged

[apps] Docker only show current containers#14152
murrant merged 5 commits intolibrenms:masterfrom
Npeca75:rrd-app-filter

Conversation

@Npeca75
Copy link
Copy Markdown
Contributor

@Npeca75 Npeca75 commented Jul 27, 2022

RRDs associated with APPs are created when new APP is discovered, but newer deleted until RRD purge period. This is normally few months/year
one of problematic APPs is Docker
Problem is that LibreNMS will stack these inactive RRDs on graph, so after few "lets try some containers" it is getting messy. Dozen of inactive RRDs are shown in cumulative graph

This PR add filter ability to filter out unused RRDs matching against active APPs in ApplicationMetrics table

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Npeca75
Copy link
Copy Markdown
Contributor Author

Npeca75 commented Jul 27, 2022

lnms1
lnms2

Before

@Npeca75
Copy link
Copy Markdown
Contributor Author

Npeca75 commented Jul 27, 2022

lnms3
lnms4

... after

Copy link
Copy Markdown
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK from me.

There is a new data field on the applications table. Just store the list of current application items there and use that to generate the graphs directly.

@Npeca75 Npeca75 marked this pull request as draft July 28, 2022 19:17
@Npeca75 Npeca75 marked this pull request as ready for review July 29, 2022 05:34
@Npeca75 Npeca75 requested a review from murrant July 29, 2022 05:34
@Npeca75
Copy link
Copy Markdown
Contributor Author

Npeca75 commented Jul 29, 2022

hi @murrant

There is a new data field on the applications table.

ok, first time dealing with this field
done as in ZFS
hope it is OK now

murrant
murrant previously approved these changes Jul 29, 2022
Copy link
Copy Markdown
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks @Npeca75

@murrant murrant changed the title [apps] enable RRD filename filtering [apps] Docker only show current containers Jul 29, 2022
@murrant murrant merged commit 1be8de0 into librenms:master Aug 7, 2022
@Npeca75 Npeca75 deleted the rrd-app-filter branch August 8, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants