[apps] Docker only show current containers#14152
Merged
murrant merged 5 commits intolibrenms:masterfrom Aug 7, 2022
Merged
Conversation
Contributor
Author
Contributor
Author
Jellyfrog
reviewed
Jul 27, 2022
Jellyfrog
reviewed
Jul 27, 2022
murrant
requested changes
Jul 28, 2022
Contributor
Author
|
hi @murrant
ok, first time dealing with this field |
murrant
previously approved these changes
Jul 29, 2022
murrant
approved these changes
Jul 29, 2022
murrant
approved these changes
Aug 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




RRDs associated with APPs are created when new APP is discovered, but newer deleted until RRD purge period. This is normally few months/year
one of problematic APPs is Docker
Problem is that LibreNMS will stack these inactive RRDs on graph, so after few "lets try some containers" it is getting messy. Dozen of inactive RRDs are shown in cumulative graph
This PR add filter ability to filter out unused RRDs matching against active APPs in ApplicationMetrics table
DO NOT DELETE THE UNDERLYING TEXT
Please note
(https://docs.librenms.org/Developing/os/Test-Units/).
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.