Standardize device and device group maintenance API#14153
Merged
murrant merged 2 commits intolibrenms:masterfrom Jul 28, 2022
Merged
Standardize device and device group maintenance API#14153murrant merged 2 commits intolibrenms:masterfrom
murrant merged 2 commits intolibrenms:masterfrom
Conversation
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
murrant
approved these changes
Jul 28, 2022
Member
murrant
left a comment
There was a problem hiding this comment.
I would be a little more strict on this, since the two API endpoints were broken up until very recently, LGTM. Improved consistency is definitely welcome.
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR standardises the behaviour of the devices and devicegroups maintenance API:
now()maintenance if no start givenPrior, the two routines made different assumptions, devices could only have immediate maintenance, and basic errors were not handled for omitted data or device not found.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.