Skip to content

Don't send zeros to Graphite for missing metrics#14262

Merged
murrant merged 1 commit intolibrenms:masterfrom
ktims:fix_zero_for_null
Sep 3, 2022
Merged

Don't send zeros to Graphite for missing metrics#14262
murrant merged 1 commit intolibrenms:masterfrom
ktims:fix_zero_for_null

Conversation

@ktims
Copy link
Copy Markdown
Contributor

@ktims ktims commented Aug 31, 2022

Fix #14258 - Graphite logic checking for empty metrics sends them as zeros instead of skipping them

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 31, 2022

CLA assistant check
All committers have signed the CLA.

@murrant
Copy link
Copy Markdown
Member

murrant commented Sep 3, 2022

Thanks!

@murrant murrant merged commit c1f6c90 into librenms:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LibreNMS submits zeros to Graphite for missing metrics

3 participants