Skip to content

API: allow delete location by id#14334

Merged
murrant merged 2 commits intolibrenms:masterfrom
bp0:del_loc_by_id
Sep 13, 2022
Merged

API: allow delete location by id#14334
murrant merged 2 commits intolibrenms:masterfrom
bp0:del_loc_by_id

Conversation

@bp0
Copy link
Copy Markdown
Contributor

@bp0 bp0 commented Sep 10, 2022

Otherwise impossible to delete location "".

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Otherwise impossible to delete location "".
Copy link
Copy Markdown
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, we need the documentation to be updated too.

@murrant murrant added the API label Sep 13, 2022
@murrant
Copy link
Copy Markdown
Member

murrant commented Sep 13, 2022

Great :)

@murrant murrant merged commit 384e044 into librenms:master Sep 13, 2022
@bp0 bp0 deleted the del_loc_by_id branch September 14, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants