Skip to content

Added status checks for (BWCC) battery status and condition for onboa…#14349

Merged
Jellyfrog merged 5 commits intolibrenms:masterfrom
quentinsch:master
Sep 16, 2022
Merged

Added status checks for (BWCC) battery status and condition for onboa…#14349
Jellyfrog merged 5 commits intolibrenms:masterfrom
quentinsch:master

Conversation

@quentinsch
Copy link
Copy Markdown
Contributor

@quentinsch quentinsch commented Sep 13, 2022

Added status checks for (BWCC) battery status and condition for onboard and PCIe RAID-controllers.
Added SNMPsim testfiles for iLO 4 and iLO5 with these changes.

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

…rd and PCIe RAID-controllers.

Added SNMPsim testfiles for iLO 4 and iLO5 with these changes.
@Jellyfrog Jellyfrog added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Sep 13, 2022
@Jellyfrog
Copy link
Copy Markdown
Member

Missing the json part of the tests

@github-actions
Copy link
Copy Markdown

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@Jellyfrog Jellyfrog removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Sep 16, 2022
@Jellyfrog Jellyfrog merged commit d0bcf0a into librenms:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Device 🖥️ New or added device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants