GitHub Workflows security hardening#14388
Merged
Jellyfrog merged 3 commits intolibrenms:masterfrom Sep 27, 2022
Merged
Conversation
Signed-off-by: Alex <aleksandrosansan@gmail.com>
Signed-off-by: Alex <aleksandrosansan@gmail.com>
Signed-off-by: Alex <aleksandrosansan@gmail.com>
|
|
Jellyfrog
reviewed
Sep 26, 2022
| super-linter: | ||
| permissions: | ||
| contents: read # to fetch code (actions/checkout) | ||
| checks: write # to mark the status of each individual linter run |
Member
There was a problem hiding this comment.
Phpstan also needs write permissions
Contributor
Author
There was a problem hiding this comment.
I have added checks: write according to the comment in super-linter action. I think phpstan is not an action and doesn't know how to call github api to make use of the permission, although GitHub should show the overall check for the job as a whole - failed or succeed. Please, let me know if you still think it is better to grant checks: write to the phpstan job.
Jellyfrog
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.