Sort alert transport by name

[SourceDoctor]

Sort Alert Transports by Name

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
• If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[Jellyfrog]

this sorts in php instead of the database

[SourceDoctor]

so how to change?

[PipoCanaja]

so how to change?

You can look at orderby SQL statement, and the way to use it in Eloquent :
https://laravel.com/docs/9.x/queries#orderby

[Jellyfrog]

Its orderBy in eloquent, and I highly doubt you can pass those flags to it, guessing it only accepts desc/asc

[SourceDoctor]

Its orderBy in eloquent, and I highly doubt you can pass those flags to it, guessing it only accepts desc/asc

\App\Models\AlertTransport::orderBy('transport_name', 'asc')->all()

seems not to work. Some ideas?

[murrant]

Suggested change

	foreach (\App\Models\AlertTransport::sortBy('transport_name', SORT_NATURAL | SORT_FLAG_CASE)->all() as $transport) {
	foreach (\App\Models\AlertTransport::all()->sortBy('transport_name', SORT_NATURAL | SORT_FLAG_CASE) as $transport) {

[murrant]

In PHP, if proper numeric sorting is important.

[murrant]

Suggested change

	foreach (\App\Models\AlertTransport::sortBy('transport_name', SORT_NATURAL | SORT_FLAG_CASE)->all() as $transport) {
	foreach (\App\Models\AlertTransport::orderBy('transport_name')->get() as $transport) {

In MySQL, it is a little more efficient at the sort.