Skip to content

McAfee Web Proxy with COUNTER rrd_type on sensors#14529

Merged
murrant merged 3 commits intolibrenms:masterfrom
PipoCanaja:mcafee
Nov 2, 2022
Merged

McAfee Web Proxy with COUNTER rrd_type on sensors#14529
murrant merged 3 commits intolibrenms:masterfrom
PipoCanaja:mcafee

Conversation

@PipoCanaja
Copy link
Copy Markdown
Contributor

@PipoCanaja PipoCanaja commented Oct 27, 2022

First YAML file using rrd_type: COUNTER
Also fixed the sensor_index cause the one used before was not stable in time (resulting in mix between graphs) (that depended on #14522)

Before (on prod):
Capture d’écran 2022-10-27 à 10 08 16

After (on test with this PR):
Capture d’écran 2022-10-27 à 10 07 26

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja added the Device 🖥️ New or added device support label Oct 27, 2022
@PipoCanaja PipoCanaja self-assigned this Oct 27, 2022
@PipoCanaja PipoCanaja added the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Oct 27, 2022
@github-actions
Copy link
Copy Markdown

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja PipoCanaja removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Oct 29, 2022
murrant
murrant previously approved these changes Nov 2, 2022
Copy link
Copy Markdown
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PipoCanaja
Copy link
Copy Markdown
Contributor Author

LGTM

@murrant Should I merge this one which currently includes #14522 or should we merge 14522 first and then merge this one after ?

@PipoCanaja
Copy link
Copy Markdown
Contributor Author

LGTM

All good now.

@murrant murrant merged commit bd4c2d7 into librenms:master Nov 2, 2022
@PipoCanaja PipoCanaja deleted the mcafee branch December 10, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Device 🖥️ New or added device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants