Skip to content

Remove ungrouped devices panel#14664

Merged
murrant merged 1 commit intolibrenms:masterfrom
murrant:remove-ungrouped-devices-panel
Nov 22, 2022
Merged

Remove ungrouped devices panel#14664
murrant merged 1 commit intolibrenms:masterfrom
murrant:remove-ungrouped-devices-panel

Conversation

@murrant
Copy link
Copy Markdown
Member

@murrant murrant commented Nov 22, 2022

The panel destroyed the page performance on larger installs.
Now has a link to the devices list with new group=none

image

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

The panel destroyed the page performance on larger installs.
Now has a link to the devices list with new group=none filter.
@murrant murrant added the WebUI label Nov 22, 2022
@murrant murrant merged commit a6e1c11 into librenms:master Nov 22, 2022
@murrant murrant deleted the remove-ungrouped-devices-panel branch November 22, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants