Skip to content

Device - Add support for Scalance SC646-2C#14835

Merged
murrant merged 2 commits intolibrenms:masterfrom
jellejans:master
Mar 21, 2023
Merged

Device - Add support for Scalance SC646-2C#14835
murrant merged 2 commits intolibrenms:masterfrom
jellejans:master

Conversation

@jellejans
Copy link
Copy Markdown
Contributor

@jellejans jellejans commented Feb 8, 2023

Add support for Scalance SC646-2C

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Add support for Scalance SC646-2C
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 8, 2023

CLA assistant check
All committers have signed the CLA.

@jellejans
Copy link
Copy Markdown
Contributor Author

librenms@vm-librenms:~$ '/usr/bin/snmpget' '-v2c' '-c' 'COMMUNITY' '-OUQn' '-m' 'SNMPv2-MIB' '-M' '/opt/librenms/mibs' 'udp:IP:161' 'sysName.0' 'sysObjectID.0' 'sysDescr.0'
.1.3.6.1.2.1.1.5.0 = NWC10_SC646
.1.3.6.1.2.1.1.2.0 = .1.3.6.1.4.1.4329.6.1.2.3
.1.3.6.1.2.1.1.1.0 = Siemens, SIMATIC NET, SCALANCE SC646-2C, 6GK5 646-2GS00-2AC2, HW: Version 1, FW: Version V02.01.03, SVPM7138185

@PipoCanaja PipoCanaja added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Feb 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 8, 2023

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja PipoCanaja changed the title Update scalance.yaml Device - Add support for Scalance SC646-2C Feb 8, 2023
@Jellyfrog
Copy link
Copy Markdown
Member

missing the second step of the test data.

@murrant murrant merged commit ae429d9 into librenms:master Mar 21, 2023
@murrant murrant removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Mar 21, 2023
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-4-0-changelog/21194/1

TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request Aug 9, 2023
* Update scalance.yaml

Add support for Scalance SC646-2C

* add scalance_sc646.snmprec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Device 🖥️ New or added device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants