Added graphing of DDoS-protection related OIDs for PAN-OS

[bakerds]

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
• If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply 14847
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[bakerds]

I had difficulty generating tests/data/panos.json with the new OIDs, however the data is present in the snmprec file included in this PR.

[Jellyfrog]

Youre missing actually polling the data in includes/definitions/discovery/panos.yaml, and therefor no test data is updated.

[github-actions]

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

[bakerds]

Hi @Jellyfrog
It works though, and the other special firewall graphs that already exist aren't defined in includes/definitions/discovery/panos.yaml

Edit -- there is no test data in tests/data/panos.json for the other graphs either, actually. For example, there's a pre-existing custom graph for panSessionActiveICMP, which is not polled anywhere else, and does not appear in tests/data/panos.json

@murrant thoughts on this?

[bakerds]

Can someone review this for merging? As far as I can tell, the unit tests don't work for this type of graph/data.

[librenms-bot]

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-5-0-changelog/21481/1