add type checking to generic_stats.inc.php for $vars['to'] and $vars['from']#14871
Merged
Jellyfrog merged 2 commits intolibrenms:masterfrom Mar 2, 2023
Merged
add type checking to generic_stats.inc.php for $vars['to'] and $vars['from']#14871Jellyfrog merged 2 commits intolibrenms:masterfrom
Jellyfrog merged 2 commits intolibrenms:masterfrom
Conversation
Jellyfrog
approved these changes
Mar 2, 2023
Member
|
@VVelox this works, but GraphParameters should contain the actual timediff. $timediff = $graph_params->to - $graph_params->from;Try to use $graph_params over $vars when possible :) |
Contributor
Author
Nice! Did not know about those. Thanks! <3 |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
…'from'] (librenms#14871) * make sure the $vars['from'] and $vars['to'] are actually numeric * style fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the issues with generic_stats.inc.php passing it from=-24hour/to=now instead of integers.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.