Skip to content

Re-throw exceptions if we're in CI#14890

Merged
Jellyfrog merged 1 commit intolibrenms:masterfrom
Jellyfrog:tests/rethrow-on-exception
Mar 10, 2023
Merged

Re-throw exceptions if we're in CI#14890
Jellyfrog merged 1 commit intolibrenms:masterfrom
Jellyfrog:tests/rethrow-on-exception

Conversation

@Jellyfrog
Copy link
Copy Markdown
Member

Else they are not shown during tests

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Else they are not shown during tests
@Jellyfrog Jellyfrog added the Tests 🧪 Test for Code label Mar 9, 2023
@Jellyfrog Jellyfrog merged commit e9f8e64 into librenms:master Mar 10, 2023
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-4-0-changelog/21194/1

TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request Aug 9, 2023
Else they are not shown during tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests 🧪 Test for Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants