Add initial OS detection for LoadBalancer.org#14902
Conversation
Co-authored-by: Tony Murray <murraytony@gmail.com>
|
Please add test data so we can ensure your change is not broken in the future. |
|
Chris Ware seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Sorry, I committed as the wrong author. Now amended but don't know if that will clear the CLA whinge. |
|
Chris Ware seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
They are not amended yet |
|
I fixed all the authors and (I think) accepted the CLA under the erroneous author email but that check still won't pass. Please just review this on its technical merits and accept anyway if OK - there are tests now. |
|
Author on one of the commits is different than your github id. I'll just merge this as you have signed the cla with your github account. |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
* Add initial OS detection for LoadBalancer.org * Match on Linux sysObjectID first for efficiency Co-authored-by: Tony Murray <murraytony@gmail.com> * Add test for loadbalancer OS detection * Add test for loadbalancer OS detection - fix author * Add test for loadbalancer OS detection * Add test for loadbalancer OS detection - fix author --------- Co-authored-by: Tony Murray <murraytony@gmail.com> Co-authored-by: Chris Ware <cjw26@bath.ac.uk>
Add initial OS detection for Loadbalancer.org OS, formerly detected as Linux
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.