Skip to content

Add initial OS detection for LoadBalancer.org#14902

Merged
murrant merged 9 commits intolibrenms:masterfrom
cjwbath:loadbalancer-dot-org-os
Apr 7, 2023
Merged

Add initial OS detection for LoadBalancer.org#14902
murrant merged 9 commits intolibrenms:masterfrom
cjwbath:loadbalancer-dot-org-os

Conversation

@cjwbath
Copy link
Copy Markdown
Contributor

@cjwbath cjwbath commented Mar 15, 2023

Add initial OS detection for Loadbalancer.org OS, formerly detected as Linux

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Co-authored-by: Tony Murray <murraytony@gmail.com>
@Jellyfrog Jellyfrog added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Mar 16, 2023
@github-actions
Copy link
Copy Markdown

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@Jellyfrog Jellyfrog closed this Mar 16, 2023
@Jellyfrog Jellyfrog reopened this Mar 16, 2023
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cjwbath
❌ Chris Ware


Chris Ware seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cjwbath
Copy link
Copy Markdown
Contributor Author

cjwbath commented Mar 16, 2023

Sorry, I committed as the wrong author. Now amended but don't know if that will clear the CLA whinge.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cjwbath
❌ Chris Ware


Chris Ware seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Jellyfrog
Copy link
Copy Markdown
Member

They are not amended yet

@cjwbath
Copy link
Copy Markdown
Contributor Author

cjwbath commented Apr 4, 2023

I fixed all the authors and (I think) accepted the CLA under the erroneous author email but that check still won't pass. Please just review this on its technical merits and accept anyway if OK - there are tests now.

@murrant
Copy link
Copy Markdown
Member

murrant commented Apr 7, 2023

Author on one of the commits is different than your github id. I'll just merge this as you have signed the cla with your github account.

@murrant murrant merged commit bbe752b into librenms:master Apr 7, 2023
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-5-0-changelog/21481/1

TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request Aug 9, 2023
* Add initial OS detection for LoadBalancer.org

* Match on Linux sysObjectID first for efficiency

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: Chris Ware <cjw26@bath.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants