Expand discovery of gigavue os#14933
Merged
murrant merged 3 commits intolibrenms:masterfrom Apr 14, 2023
Merged
Conversation
- Expand discovery so all Gigamon products are discovered - Query for hardware version using GIGAMON-SNMP-MIB::model.0 OID if present - Add more Gigamon gigavue test data
Looks like there was no json file before...
Contributor
Author
|
I inadvertently did not generate the gigavue_hc2.json. @murrant thank you for generating it. I will resolve the failed checks. |
Contributor
Author
|
@murrant @electrocret, is anything else needed to merge these changes? |
murrant
approved these changes
Apr 14, 2023
Member
|
Heh, LGTM. @murrant beat me to the approve. |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
TheMysteriousX
pushed a commit
to TheMysteriousX/librenms
that referenced
this pull request
Aug 9, 2023
* Expand discovery of gigavue os - Expand discovery so all Gigamon products are discovered - Query for hardware version using GIGAMON-SNMP-MIB::model.0 OID if present - Add more Gigamon gigavue test data * Create gigavue_hc2.json Looks like there was no json file before... * update gigavue_hc2.json --------- Co-authored-by: Tony Murray <murraytony@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.