Skip to content

RouterOS Vlan agent script clarification#15158

Merged
murrant merged 1 commit intolibrenms:masterfrom
viptampa:patch-1
Jul 24, 2023
Merged

RouterOS Vlan agent script clarification#15158
murrant merged 1 commit intolibrenms:masterfrom
viptampa:patch-1

Conversation

@viptampa
Copy link
Copy Markdown
Contributor

@viptampa viptampa commented Jul 24, 2023

Provided clarity on how to install the RouterOS Vlan agent script.

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Provided clarity on how to install.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@murrant murrant merged commit f9d1623 into librenms:master Jul 24, 2023
@murrant murrant changed the title Update Routeros.md RouterOS Vlan agent script clarification Jul 24, 2023
TheMysteriousX pushed a commit to TheMysteriousX/librenms that referenced this pull request Aug 9, 2023
Provided clarity on how to install.
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-8-0-changelog/22078/1

peejaychilds pushed a commit to peejaychilds/librenms that referenced this pull request Oct 26, 2023
Provided clarity on how to install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants