Fix manual port speed storage#15238
Merged
murrant merged 4 commits intolibrenms:masterfrom Aug 21, 2023
Merged
Conversation
Due to a bug all manually configured port speeds were lost and will need to be reconfigured. This allows them to work in a way that will prevent that issue in the future by storing the speed with the override. Includes notification.
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/librenms-port-settings-getting-reverted-to-10-mbps/22022/4 |
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Aug 23, 2023
fixes bug introduced in 23.8.0 where port speeds which have been manually overridden were accidentally reset to '1'; more info at librenms/librenms#15238
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* Fix port speed setting Due to a bug all manually configured port speeds were lost and will need to be reconfigured. This allows them to work in a way that will prevent that issue in the future by storing the speed with the override. Includes notification. * Fix date * Add URL * Spelling fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug all manually configured port speeds were lost and will need to be reconfigured.
This allows them to work in a way that will prevent that issue in the future by storing the speed with the override.
Includes a notification.
To find ports set incorrectly, you can run this command:
lnms tinker --execute="dump(DeviceAttrib::where('attrib_type', 'like', 'ifSpeed:%')->where('attrib_value', '1')->select(['device_id', 'attrib_type', 'attrib_value'])->get()->toArray() ?: 'None found')"Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.