Conversation
|
Can you add skip_value: -99 (or -990 whatever it is)? This many sensors for ports without modules is ridiculous :D |
Yeah.... I think the original committer used a device in a lab for test units, and it didn't actually have anything connected to it. Probably how the typo got overlooked. Once I fixed it data popped right in for my equipment. |
|
I'm actually ready for review with this PR now. Thought I'd do some prettying up since I was tinkering with it. Edit- I lied. Someone on my team pointed out another issue with multi line card models. |
|
Alrighty, now I'm done. Edit - I lied again. The Sensor Grouping was making my brain itch cause it was wholly unnecessary since I didn't find much else in the MIB worth tracking. |
|
Alrighty, this PR is ready. Someone please approve and merge before I find something else to nit pick about it. @murrant @Jellyfrog @VVelox 😄 |
VVelox
left a comment
VVelox
left a comment
There was a problem hiding this comment.
Hmm, looks good to me. I am not seeing anything that looks crazy or the like off hand, but I'm by far not the most familiar with this area of discovery.
So likely would be good to have some one take a second peak at it.
PipoCanaja
left a comment
PipoCanaja
left a comment
There was a problem hiding this comment.
LGTM indeed, as far as I can tell without owning a device :)
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
* Update smartos-dcp-m.yaml * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Remove bogus 0 values * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update DCP-INTERFACE-MIB * Update SO-TC-MIB * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Update smartos-dcp-m.yaml * Test data update * Update smartos-dcp-m.yaml * Update smartos-dcp-m_dcp-m40-pam4-zr.json * Remove Grouping * Update Test
6 participants
Appears to have been a typo
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.