Improve "count" graphs for F5OS#15335
Merged
murrant merged 3 commits intolibrenms:masterfrom Sep 25, 2023
Merged
Conversation
Contributor
|
This fixes my problem, see: #15334 (comment) |
murrant
reviewed
Sep 20, 2023
murrant
approved these changes
Sep 25, 2023
peejaychilds
pushed a commit
to peejaychilds/librenms
that referenced
this pull request
Oct 26, 2023
* fix rrd_type: COUNTER and change index to force new graphs * tests * remove number in index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #15334, change to Counter instead of Gauge for graphs. This will reset the graphs but the PR is fairly new and the current graphs are useless anyway so it won't be an issue I would say.
PR fixes #15241 and fixes #15334
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 15335After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.