Skip to content

Fix a few XSS vulnerabilities in device group popups#15581

Merged
murrant merged 1 commit intolibrenms:masterfrom
murrant:fix-device-group-xss
Nov 15, 2023
Merged

Fix a few XSS vulnerabilities in device group popups#15581
murrant merged 1 commit intolibrenms:masterfrom
murrant:fix-device-group-xss

Conversation

@murrant
Copy link
Copy Markdown
Member

@murrant murrant commented Nov 15, 2023

I can't tell if the flasher ones are vulnerable, as flasher is still broken.

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

I can't tell if the flasher ones are vulnerable, as flasher is still broken.
@murrant murrant merged commit faf6603 into librenms:master Nov 15, 2023
@murrant murrant deleted the fix-device-group-xss branch November 15, 2023 14:21
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-11-0-changelog/22833/1

gdepeyrot pushed a commit to gdepeyrot/librenms that referenced this pull request Nov 29, 2023
I can't tell if the flasher ones are vulnerable, as flasher is still broken.
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
I can't tell if the flasher ones are vulnerable, as flasher is still broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants