Skip to content

Give reason for alert template fallback#15583

Merged
laf merged 2 commits intolibrenms:masterfrom
murrant:default-template-error
Nov 16, 2023
Merged

Give reason for alert template fallback#15583
laf merged 2 commits intolibrenms:masterfrom
murrant:default-template-error

Conversation

@murrant
Copy link
Copy Markdown
Member

@murrant murrant commented Nov 16, 2023

Print the error and notice of the fallback template being used.

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Print the error and notice of the fallback template being used.
@murrant murrant added this to the 23.11.0 milestone Nov 16, 2023
Copy link
Copy Markdown
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested fine

@laf laf merged commit 2755676 into librenms:master Nov 16, 2023
@laf laf deleted the default-template-error branch November 16, 2023 15:18
@murrant murrant changed the title Fallback template, give reason Give reason for alert template fallback Nov 16, 2023
@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-11-0-changelog/22833/1

@librenms-bot
Copy link
Copy Markdown

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/some-new-alerts-not-using-alert-template/22761/4

gdepeyrot pushed a commit to gdepeyrot/librenms that referenced this pull request Nov 29, 2023
* Fallback template, give reason
Print the error and notice of the fallback template being used.

* more strict typing
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
* Fallback template, give reason
Print the error and notice of the fallback template being used.

* more strict typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants