Implement [Replace] for rust-crypto

[sashahilton00]

Option 5 from #128, usea replace tag to switch to avx2 branch from awmath/rust-crypto. Closes #128

[plietar]

This needs to be done in every crate, eg core/Cargo.toml.

[sashahilton00]

slipped my mind, will do that now.

[plietar]

These should only be at the root though.

[sashahilton00]

so [replace] propagates to dependencies?

[sashahilton00]

Fixed up the history, let me know if anything else needs adjusting.

[awiouy]

Should there not be a [replace] statement in every Cargo.toml?

[sashahilton00]

Originally I had that, but Paul says it's only necessary in the root Cargo.toml, presumably it propagates

[plietar]

From https://doc.rust-lang.org/cargo/reference/manifest.html#the-workspace-section

The [patch] and [replace] sections in Cargo.toml are only recognized in the root crate's manifest, and ignored in member crates' manifests.

[michaelherger]

As I'm using librespot as a library for my own application, would I have to add the [replace] section to my own project's Cargo.toml, though I don't use it in there directly?

[plietar]

@michaelherger I think so. You can try with and without the [replace] section and see which version of rust-crypto cargo is building.

If the section is correctly defined you should get:

Compiling rust-crypto v0.2.36 (https://github.com/awmath/rust-crypto.git?branch=avx2#394c2472)

Otherwise you just get

Compiling rust-crypto v0.2.36

[michaelherger]

Interesting: it's compiling the avx2 branch, without any modification on my end. I'll keep this in mind. Just in case there were unexpected issues. Thanks!