Make sequences wrap around to avoid overflows#438
Merged
sashahilton00 merged 1 commit intolibrespot-org:devfrom Feb 27, 2020
Malvineous:patch-3
Merged
Make sequences wrap around to avoid overflows#438sashahilton00 merged 1 commit intolibrespot-org:devfrom Malvineous:patch-3
sashahilton00 merged 1 commit intolibrespot-org:devfrom
Malvineous:patch-3
Conversation
Instead of aborting with an `attempt to add with overflow` error, wrap the sequence around so that it goes back to 0 once it has reached the maximum value for the integer type. Fixes #437.
paulfariello
pushed a commit
to paulfariello/librespot
that referenced
this pull request
Sep 23, 2025
Make sequences wrap around to avoid overflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of aborting with an
attempt to add with overflowerror, wrap the sequence around so that it goes back to 0 once it has reached the maximum value for the integer type. Fixes #437.Everything that uses sequences seems to treat them as unique values for matching asynchronous responses back to requests, so having the sequence number wrap at some point long after the original response has been received should cause no problems.