Attenuate after normalisation#840
Merged
roderickvd merged 2 commits intolibrespot-org:devfrom Sep 2, 2021
Merged
Conversation
paulfariello
pushed a commit
to paulfariello/librespot
that referenced
this pull request
Sep 23, 2025
Attenuate after normalisation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change just to do things right: volume control should be the last in line, after normalisation and potentially other filters. In practice very few if any will notice.
At the same time I removed the clamping of floating point samples. It's not necessary, when converting to integer samples the conversion will saturate at the bounds (i.e. clip) anyway.