Fix for #1069 #1071
Closed
Fix for #1069 #1071
+15
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n() distinguishable from sockets by having them take odd values only
Contributor
|
Hi @datadiode, interesting solution. How does this work when the file descriptors are passed in by the calling program or library though? |
Contributor
Author
|
You mean if they mean to pass a file descriptor to e.g. SSL_set_fd()? |
Contributor
|
I finally got a chance to test this out. It seems to break console IO when using openssl.exe. As soon as there is console IO, the program exits: |
…which lives in poll_win.c)
Merged
Contributor
|
Closing this out since the patches here were cherry picked into #1150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed change makes file descriptors created through posix_open() distinguishable from sockets by having them take odd values only.