Skip to content

Only match records with exactly 1 APIS holding in excludeEplikt#524

Merged
olovy merged 1 commit intodevelopfrom
bugfix/lws-293-eplikt-filter
Apr 29, 2025
Merged

Only match records with exactly 1 APIS holding in excludeEplikt#524
olovy merged 1 commit intodevelopfrom
bugfix/lws-293-eplikt-filter

Conversation

@olovy
Copy link
Copy Markdown
Contributor

@olovy olovy commented Apr 28, 2025

No description provided.

Copy link
Copy Markdown
Contributor

@kwahlin kwahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@lrosenstrom lrosenstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚢

@olovy olovy merged commit 8a5cc20 into develop Apr 29, 2025
@olovy olovy deleted the bugfix/lws-293-eplikt-filter branch April 29, 2025 07:44
@jannistsiroyannis
Copy link
Copy Markdown
Contributor

jannistsiroyannis commented Apr 29, 2025

Is there not a problem with applying filters this way?
For example if the (slightly broken) original query is:
blabla OR
And we append:
NOT (bibliography:\"sigel:EPLK\")
Things get kinda wierd, right?

Should filters not instead be more like:
( [ORIGINAL QUERY] ) AND NOT (bibliography:\"sigel:EPLK\")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants