Add filter for free digital material#525
Merged
lrosenstrom merged 5 commits intodevelopfrom May 2, 2025
Merged
Conversation
olovy
reviewed
Apr 29, 2025
olovy
reviewed
Apr 29, 2025
Contributor
olovy
left a comment
There was a problem hiding this comment.
Note that we can't be sure that e.g. usageAndAccessPolicy and type:Electronic match the same instance since instances are not nested in ES. This should not be a problem in practice. And as you say, the filter should be based on more exact symbols.
See comment about wildcards. Other than that, LGTM
olovy
approved these changes
Apr 29, 2025
0392c14 to
2f3912c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See description in LWS-242.
Edit: @olovy pointed out that we should probably add https://id.kb.se/policy/freely-available and https://id.kb.se/policy/oa/gratis to the filter, so those two access policies are also included now.