Sync aho corasick #340
Merged
Sync aho corasick #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-d-mitchell
force-pushed
the
sync-aho-corasick
branch
from
61ff702 to
fe059fe
Compare
Refactored argument parsing for better readability and removed unused --show-skipped option. Enhanced C++ comment stripping, added variable detection, and improved search patterns for functions and attributes in C++ files. Updated skip logic to use Console for output and improved match reporting for found and possibly found items.
Collaborator
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
There was a problem hiding this comment.
AhoCorasick changes look good to me, and the check sync stuff seems to work for me too once I had installed rich. Please could you add rich to the dev environment. After that, I'm happy to merge
| def find_in_cpp(args, thing: str, fn: str, info: dict) -> None: | ||
| if _skip(args, thing, fn): | ||
| return | ||
| def _strip_cxx_comments(lines: list[str]) -> list[str]: |
Collaborator
There was a problem hiding this comment.
Is it necessary to also remove comments of the following form:
/*
This is a comment
*/
Member
Author
There was a problem hiding this comment.
We don't ever use these (this is also complained about by cpplint I think), so I think the answer is "no"
james-d-mitchell
force-pushed
the
sync-aho-corasick
branch
from
fe059fe to
c98933c
Compare
Member
Author
|
I've added rich to the dev-environment.yml file, are we good to go? @Joseph-Edwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
AhoCorasickto be better in sync with libsemigroups, and some other minor fixes, including in the check_sync script.