clang-tidy: readability-inconsistent-declaration-parameter-name

[karel-m]

Running

clang-tidy-3.9 src/*/*.c src/*/*/*.c src/*/*/*/*.c src/*/*/*/*/*.c \
   --checks=-*,readability-inconsistent-declaration-parameter-name \
   -- -DLTC_SOURCE -DUSE_LTM -DLTM_DESC -Isrc/headers -I../libtommath

reveals couple of cases (approx. 40) where we have inconsistent function declaration in *.h and *.c like:

src/headers/tomcrypt_hash.h:426:5: warning: function 'md5_done' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
int md5_done(hash_state * md, unsigned char *hash);
    ^
                                             out
/home/miko/libtomcrypt/src/hashes/md5.c:258:5: note: the definition seen here
int md5_done(hash_state * md, unsigned char *out)
    ^
src/headers/tomcrypt_hash.h:426:5: note: differing parameters are named here: ('hash'), in definition: ('out')
int md5_done(hash_state * md, unsigned char *hash);
    ^

Do we want to fix them?

[sjaeckel]

TBH if it weren't for consistency I'd remove the argument names from the header files... but sure, fix them, I guess @fperrad will be happy as well :D