Improve base16 api #398
Merged
Improve base16 api #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaeckel
force-pushed
the
improve/base16_api
branch
from
b38d800 to
a2fa76f
Compare
karel-m
reviewed
Jun 3, 2018
doc/crypt.tex
Outdated
| int base16_encode(const unsigned char *in, unsigned long inlen, | ||
| char *out, unsigned long *outlen, | ||
| int caps); | ||
| unsigned long options); |
Member
There was a problem hiding this comment.
I would prefer unsigned int which is 32bit pretty everywhere. With unsigned long there might be a trouble that it is only 32bit on Windows/x86 but 64bit on many other platforms.
sjaeckel
force-pushed
the
improve/base16_api
branch
2 times, most recently
from
844d266 to
93b2983
Compare
karel-m
approved these changes
Jun 3, 2018
probably we want to add more options in the future I could think of support for some options of `xxd` resp. `hexdump`
sjaeckel
force-pushed
the
improve/base16_api
branch
from
93b2983 to
06c0606
Compare
Member
|
I have merged this one so that I can continue with merging #400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in the commit-message:
e.g. the little-endian encoding of 2**n byte values